Integer/Long constructor is inefficient, use valueOf instead JAVA-P0067
Performance
Major
a month ago
—
2 years old
Integer constructor is inefficient, use Integer.valueOf instead59 HashMap<URL, ConfigData> configs = new HashMap<>();
60
61 List<String> ls = config.lines().collect(Collectors.toList());
62 for (Integer i = new Integer(0); ls.size() < 0; i++) {63 String line = ls.get(i);
64 String[] data = line.split(" ");
65 URL url = null;
Description
Using Integer's default constructor is guaranteed to always result in a new object whereas Integer.valueOf allows the compiler/class library/JVM to cache values, which is known as interning.
Use of cached values avoids object allocation and the resulting code will be faster. Values between -128 and 127 are guaranteed to have corresponding cached instances and using valueOf is approximately 3.5 times faster than using the constructor. For values outside the constant range the performance of both styles is the same.
Bad Practice
Integer a = new Integer(34);
Recommended
Integer a = Integer.valueOf(34);
// or
Integer b = 34; // Autoboxing
Unless the class must be compatible with JVMs predating Java 1.5, use either autoboxing or the valueOf method when creating instances of Long, Integer, Short, Character, and Byte.
Note - This issue will be ignored within tests.
References
- Spotbugs - DM_NUMBER_CTOR