51 StringBuffer sb = new StringBuffer();
52 HttpClient hc = HttpClient.newBuilder().build();
53 HttpRequest offerReq = HttpRequest.newBuilder(offerAPI).GET().build();
54 Cipher ci = Cipher.getInstance("DES/ECB/PKCS5Padding"); 55
56 HttpResponse<String> offerResp = hc.send(offerReq, HttpResponse.BodyHandlers.ofString());
57ECB and CBC encryption modes are both known to be insecure due to a number of attacks that they make possible. As the default encryption mode in Java is ECB, this issue will be raised if only the algorithm is specified in a cipher transformation.
CBC encryption mode with any padding scheme is inherently susceptible to padding oracle attacks. An adversary could potentially decrypt the message if the system exposed the difference between plaintext with invalid padding or valid padding. The distinction between valid and invalid padding is usually revealed through distinct error messages being returned for each condition.
Similarly, there are a host of vulnerabilities associated with ECB mode which may be used to circumvent encryption.
Bad Practice
Cipher c1 = Cipher.getInstance("AES/CBC/PKCS5Padding");
Cipher c2 = Cipher.getInstance("AES"); // Java's default cipher provider sets mode to ECB if no mode is specified.
Recommended
It is better to use an encryption mode which does not allow for such attacks and also incorporates integrity verification, such as Galois/Counter Mode (GCM). Additionally, always make sure to specify the full transformation string when specifying a cipher to instantiate.
Cipher c = Cipher.getInstance("AES/GCM/NoPadding");
Note: Server-side code must ensure that data is verified for integrity before attempting to decrypt it. In the case of a padding oracle attack, the attacker would need to send data with compromised integrity as a part of the attack, and proper integrity verification via HMACs is generally enough to thwart such malicious traffic. Use an encryption mode which comes with HMAC integrity checks for best results.
References
- FindSecBugs - PADDING_ORACLE
- CAPEC-463 - Padding Oracle Crypto Attack
- CWE-310 - Cryptographic Issues
- CWE-327 - Use of a Broken or Risky Cryptographic Algorithm
- OWASP Top Ten (2021) - Category A02 - Cryptographic Failures
- NIST - Authenticated Encryption Modes