if statements can be merged PTC-W0048
Anti-pattern
Major
a month ago
—
2 years old
Consider merging collapsible if statements
5 self.val = val
6
7 def __add__(self, other):
8 if isinstance(self, RealNumber): 9 if isinstance(other, RealNumber):
10 return self.val + other.val
11
Description
Nested if statements can be collapsed into a single if statement by separating their condition using and operator.
Merging collapsible if statements increases the code's readability.
Bad practice
if condition1:
if condition2:
dosomething()
Preferred
if condition1 and condition2:
dosomething()
Exception:
DeepSource will not raise this issue when the nested if statements have comments in between them, as it could be explaining why the nested if is in place.