Set declaration has duplicate elements PTC-W0050
Anti-pattern
Major
a month ago
—
2 years old
Set has multiple entries for element 1
23
24
25def play_with_magic_numbers():
26 magic_numbers = {0, 1, 1, 2, 3, 5}27 magic_numbers.add(8)
28
29 for elem in magic_numbers:
Description
A set cannot have two identical values. When a value is repeated in a set literal,
only the last occurrence will remain. Thus duplicate values should be either modified or removed.
If duplicate elements are needed, that is, multiset, use Counter from collections module.
Not preferred:
my_set = {"one", "two", "one"}
def myfunc(a, b, c):
my_set = {a, b, a, c}
Preferred:
my_set = {"one", "two", "one"}
def myfunc(a, b, c):
my_set = {a, b, c}