Adding to set immediately following its definition PY-W0071
Anti-pattern
Major
a month ago
—
2 years old
Adding to set immediately following its definition
23
24
25def play_with_magic_numbers():
26 magic_numbers = {0, 1, 1, 2, 3, 5}27 magic_numbers.add(8)
28
29 for elem in magic_numbers:
Description
Instead of addepts items to a set just after creation, it should be refactored to add those items into the set definition itself.
Bad practice
trees = set()
trees.add('cedar')
trees.add('oak')
Recommended
trees = {'cedar', 'oak'}