PYL-R1701 · Consider merging `isinstance` calls

QuackatronHQ / Gigarepo

Active

Consider merging isinstance calls PYL-R1701

Anti-pattern

Major

a month ago — 2 years old

Consider merging these isinstance calls to isinstance(baz, (float, int))

123        and isinstance(other_obj, float)
124        and isinstance(foo, str)
125        or (isinstance(bar, float) or isinstance(bar, str))
126        and (isinstance(baz, float) or isinstance(baz, int))127    ):
128        pass
129

Consider merging these isinstance calls to isinstance(bar, (float, str))

python/demo_code.py

122        )
123        and isinstance(other_obj, float)
124        and isinstance(foo, str)
125        or (isinstance(bar, float) or isinstance(bar, str))126        and (isinstance(baz, float) or isinstance(baz, int))
127    ):
128        pass

Consider merging these isinstance calls to isinstance(object, (float, int, str))

python/demo_code.py

116    if (
117        initial_condition
118        and (
119            isinstance(object, int)120            or isinstance(object, float)
121            or isinstance(object, str)
122        )

Description

You can pass a tuple of types you want to check as the second argument to isinstance. If the object matches with any of the types, it will return True else False.

It is therefore recommended to merge multiple consecutive isinstance calls into one. It is clearer and improves readability.

# Instead of
if isinstance(i, int) or isinstance(i, float):
    print('A number')

# Do this
if isinstance(i, (int, float)):
    print('A number')