Unused parameter in function RVV-B0012
Bug risk
a month ago
—
6 months old
parameter 'clear' seems to be unused, consider removing or renaming it as _
16
17var xxhash = xxHash32.New(randomSeed()) // hash.Hash32
18
19func fastHash(clear bool, buf []byte) uint32 {20 xxhash.Reset()
21 xxhash.Write(buf)
22 return xxhash.Sum32()
Description
Unused parameters in functions or methods should be replaced with _
(underscore) or removed.
Functions or methods with unused parameters can be a symptom of unfinished
refactoring or a bug. If an unused parameter is present, it should be named _
(underscore) to avoid raising this issue and better readability.
Bad practice
func abc(unused string) {
fmt.Println("Not using any passed params.")
}
Recommended
func abc(_ string) {
fmt.Println("Not using any passed params.")
}
func abc() {
fmt.Println("Not using any passed params.")
}