Appending to dictionary immediately following its definition PY-W0072
Anti-pattern
Major
2 years ago
—
2 years old
Appending to list immediately following its definition
3with open("README.md", "r") as fh:
4 long_description = fh.read()
5
6extras = {} 7extras["torch"] = ["torch>=1.5,<2.2"]
8extras["all"] = extras["torch"]
9extras["docs"] = ["mkdocs-material"]
Description
Instead of adding items to a dictionary just after creation, it should be refactored to add those items into the dict definition itself.
Bad practice
env = {}
env['HOST'] = 'example.com'
env['PORT'] = 8080
Recommended
env = {'HOST': 'example.com', 'PORT': 8080}