Found empty block statements JS-0009
Anti-pattern
Minor
3 months ago
—
a year old
Empty block statement
722 this.gcodeProcessor.doUpdate();
723 this.scene.render(true, true)
724 this.scene.onAfterRenderObservable.addOnce(() => { renderComplete = true });
725 while (!renderComplete) { } 726 var data = await ScreenshotTools.CreateScreenshotAsync(this.engine, this.scene.activeCamera, { width: width, height: height }) //, precision: 2
727 this.scene.clearColor = clearColor
728 return data
Description
Empty block statements, while not technically errors, usually occur due to refactoring that wasn't completed. They can mislead the reader.
If you still want to keep an empty block, add a comment saying empty inside the block.
Bad Practice
if (someCheck) {}
while (someCheck) {}
try {
doSomething();
} catch(err) {
} finally {
}
Recommended
if (someCheck) {
// empty
}
while (someCheck) {
/* empty */
}
try {
doSomething();
} catch (err) {
// continue regardless of error
}
try {
doSomething();
} finally {
/* continue regardless of error */
}