Either all code paths should have explicit returns, or none of them JS-0045
Anti-pattern
Minor
3 months ago
—
a year old
Method 'getVoxelSegments' expected no return value
141 }
142 pointArray.push(...depthPoints);
143 }
144 return pointArray; 145 }
146
147 Method 'buildBed' expected no return value
84 this.buildBox();
85 break;
86 }
87 return this.bedMesh; 88 }
89 setDelta(isDelta) {
90 this.isDelta = isDelta; Method 'buildBed' expected no return value
74 if (this.bedMesh && this.bedMesh.isDisposed()) {
75 this.bedMesh = null;
76 }
77 if (this.bedMesh) return this.bedMesh; 78
79 switch (this.renderMode) {
80 case RenderBedMode.bed:
Description
Any code paths that do not have explicit returns will return undefined.
It is recommended to replace any implicit dead-ends that return undefined with a return null statement.
As a convention, undefined signals that an unexpected value has been produced as the
result of a logical error in the program.
A null return, on the other hand, signals that the input to a function was incorrect,
or a value was 'not found'.
Having this distinction in code helps you figure out if something was caused because of a logical error, or malformed input to a function call.
Bad Practice
function getUser(name) {
if (userExists(name)) {
return userDb.get(name);
}
// whoops! Implicit undefined return
}
function readFile(fileName) {
if (fs.existsSync(fileName)) {
return fs.readFileSync(fileName, 'utf-8');
}
return; // Implicit undefined return.
}
Recommended
function getUser(name) {
if (userExists(name)) {
return userDb.get(name);
}
// `null` indicates there is no such user.
return null;
}
function readFile(fileName) {
if (fs.existsSync(fileName)) {
return fs.readFileSync(fileName, 'utf-8');
}
// `null` indicates there is no such file.
return null;
}