Found empty functions JS-0057
Anti-pattern
Minor
3 months ago
—
a year old
Unexpected empty arrow function
133
134 this.cancelLoad = false;
135
136 this.loadingProgressCallback = () => {}; 137
138 this.hasSpindle = false;
139Unexpected empty arrow function
12 this.scene = scene;
13 this.workplacePoints = [];
14 this.workplaceMeshes = [];
15 this.registerClipIgnore = () => { }; 16 }
17
18 setOffsets(points) { Unexpected empty method 'goToGCodeLine'
609 return this.gcodeProcessor.currentLineNumber;
610 }
611
612 goToGCodeLine(lineNumber) {} 613
614 simulateToolPosition() {
615 this.updateToolPosition(this.gcodeProcessor.nozzlePosition); Unexpected empty function
288 }
289
290 refreshUI() {
291 setTimeout(function () {}, 0); 292 }
293
294 resetCamera() { Unexpected empty arrow function
76 this.simulationCurrentLine = null;
77 this.simulationMultiplier = 1;
78 this.simulationUpdatePosition = () => {};
79 this.simulationStopped = () => {}; 80 this.simLine = Vector3.Zero();
81 this.isMMS = false;
82 }
Description
Having empty functions hurts readability, and is considered a code-smell. There's almost always a way to avoid using them. If you must use one, consider adding a comment to inform the reader of its purpose.
Bad Practice
getUser('SwaGaLisTiQuE', () => {})
function f() {}
Recommended
getUser('SwaGaLisTiQuE', () => {
// empty because <reason>
})
function f() {
// intentionally empty. <reason>
}