JS-0119 · Initialization in variable declarations against recommended approach

Sindarius / npm_gcodeviewer

Active

Initialization in variable declarations against recommended approach JS-0119

Anti-pattern

Minor

3 months ago — a year old

Variable 'renderer' should be initialized on declaration

 898         });
 899      }
 900
 901      let renderer; 902      if (this.renderVersion === RenderMode.Line || this.renderVersion === RenderMode.Point) {
 903         renderer = new LineRenderer(scene, this.specularColor, this.loadingProgressCallback, this.renderFuncs, this.tools, this.meshIndex);
 904      } else if (this.renderVersion === RenderMode.Block) {

Variable 'tokens' should be initialized on declaration

src/gcodeprocessor.js

 718      if (commentIndex > -1) {
 719         tokenString = tokenString.substring(0, commentIndex - 1).trim();
 720      }
 721      let tokens; 722
 723      tokenString = tokenString.toUpperCase();
 724      let commands = tokenString.match(/[GM]+[0-9.]+/g); //|S+

Variable 'vertextMultiplier' should be initialized on declaration

src/gcodeprocessor.js

 277      }
 278
 279      for (let renderModeIdx = renderStartIndex; renderModeIdx < 4; renderModeIdx++) {
 280         let vertextMultiplier; 281         switch (renderModeIdx) {
 282            case 1:
 283               vertextMultiplier = 24;

Variable 'ViewBoxCallback' should be initialized on declaration

src/viewbox.js

 89  box.material= edgeMaterial; 
 90} 
 91 
 92var ViewBoxCallback;  93 
 94export function registerViewBoxCallback(func) { 
 95  ViewBoxCallback = func;

Variable 'json' should be initialized on declaration

src/tool.js

46   } 
47 
48   static fromJson(jsonString) { 
49      let json; 50      if (typeof jsonString === 'object') { 
51         json = jsonString; 
52      } else {

Description

In JavaScript, variables can be assigned during declaration, or at any point afterwards using an assignment statement. For example, in the following code, foo is initialized during declaration, while bar is initialized later.

var foo = 1;
var bar;

if (foo) {
    bar = 1;
} else {
    bar = 2;
}

Bad Practice

function foo() {
    var bar;
    let baz;
}

Sindarius / npm_gcodeviewer

Bad Practice

Recommended