Require template literals instead of string concatenation JS-0246
Anti-pattern
Minor
3 months ago
—
a year old
Unexpected string concatenation
292
293 for (let idx = this.everyNthRow; idx <= maxNRow; idx++) {
294 if (this.debug) {
295 console.log('Mode: ' + renderModeIdx + ' NRow: ' + idx + ' vertexcount: ' + (numberOfLines * vertextMultiplier) / idx); 296 }
297 if ((numberOfLines * vertextMultiplier) / idx < maxLines) {
298 this.renderVersion = renderModeIdx;Unexpected string concatenation
76 } else {
77 for (let toolIdx = 0; toolIdx < 10; toolIdx++) {
78 const tool = new Tool();
79 tool.name = 'Tool #' + toolIdx; 80 loadedTools.push(tool);
81 }
82 } Unexpected string concatenation
21 }
22
23 set colorString(value) {
24 this.color = Color4.FromHexString(value + 'FF'); 25 this.updateDarkerValue();
26 }
27 Unexpected string concatenation
85 let cancelObject = boundaryObjects[cancelObjectIdx];
86
87 let buildObject = MeshBuilder.CreateTiledBox(
88 'OBJECTMESH:' + cancelObject.name, 89 {
90 pattern: Mesh.CAP_ALL,
91 alignVertical: Mesh.TOP,
Description
In ES2015 (ES6), we can use template literals instead of string concatenation.
var str = `Hello, ${name}!`;
Bad Practice
var str = "Hello, " + name + "!";
var str = "Time: " + (12 * 60 * 60 * 1000);
Recommended
var str = "Hello World!";
var str = `Hello, ${name}!`;
var str = `Time: ${12 * 60 * 60 * 1000}`;
var str = "Hello, " + "World!";