Static fields of the parent class should not be accessed through child class instances JAVA-W1030
Anti-pattern
Major
5 months ago
—
2 years old
TOP should be accessed through SwingConstants, not JTabbedPane
152 consoleTextArea.setEditable(false);
153 consoleTextArea.setFont(Font.decode("Monospaced"));
154
155 tabbedPane.setTabPlacement(JTabbedPane.TOP);156 tabbedPane.add("Abstract Syntax Tree", astTreeScrollPane);
157 tabbedPane.add("XML", xmlScrollPane);
158 tabbedPane.add("Console", consoleScrollPane);EXIT_ON_CLOSE should be accessed through WindowConstants, not ToolkitViewImpl
138
139 private void initComponents() {
140 setSize(1000, 700);
141 setDefaultCloseOperation(ToolkitViewImpl.EXIT_ON_CLOSE);142
143 setLayout(new BorderLayout(0, 5));
144
Description
Non-private static members of the parent class are accessible by child classes. However, it is a bad practice to do so, because it obscures where a value was actually declared. Always use only the declaring class to access static members.
Bad Practice
class SomeClass {
static Object staticData = null;
}
class SomeChildClass {
public void method() {
// Accessing the static value declared within the parent class through the child class.
SomeChildClass.staticData = this;
}
}
Recommended
class SomeChildClass {
public void method() {
// We are now accessing the static value through the parent class.
SomeClass.staticData = this;
}
}