Redundant boolean literal JAVA-W1064
Bug risk
Major
5 months ago
—
a year old
Boolean literal is redundant
86 if (child != null) {
87 iterate(child, values);
88 } else {
89 if (node.getType() instanceof CxxGrammarImpl == false) {90 values.add(node.getTokenValue());
91 }
92 }Boolean literal is redundant
52 @RuleProperty(
53 key = "invertFilePattern",
54 description = "Invert file pattern comparison",
55 defaultValue = "" + DEFAULT_INVERT_FILE_PATTERN)56 public boolean invertFilePattern = DEFAULT_INVERT_FILE_PATTERN;
57
58 @RuleProperty(Boolean literal is redundant
83 @RuleProperty(
84 key = "invertRegularExpression",
85 description = "Invert regular expression comparison",
86 defaultValue = "" + DEFAULT_INVERT_REGULAR_EXPRESSION) 87 public boolean invertRegularExpression = DEFAULT_INVERT_REGULAR_EXPRESSION;
88
89 /**Boolean literal is redundant
65 @RuleProperty(
66 key = "invertFilePattern",
67 description = "Invert file pattern comparison",
68 defaultValue = "" + DEFAULT_INVERT_FILE_PATTERN) 69 public boolean invertFilePattern = DEFAULT_INVERT_FILE_PATTERN;
70
71 /**Boolean literal is redundant
83 @RuleProperty(
84 key = "invertRegularExpression",
85 description = "Invert regular expression comparison",
86 defaultValue = "" + DEFAULT_INVERT_REGULAR_EXPRESSION) 87 public boolean invertRegularExpression = DEFAULT_INVERT_REGULAR_EXPRESSION;
88
89 /**
Description
Boolean literals should not be used redundantly within expressions.
An entity that may evaluate to true or false can directly be used in an expression where a boolean value is expected. Boolean literals are almost never necessary in any expression.
Bad Practice
public void method() {
if (returnsBoolean() == true) { //.. }
if (boolVar || false) { // .. }
if (boolVar && true) { // .. }
}
Recommended
Consider removing the redundant literals.
public void method() {
if (returnsBoolean()) { //.. }
if (boolVar) { // .. }
if (boolVar) { // .. }
}