For loop can be converted into a foreach loop JAVA-W1089
Anti-pattern
Minor
6 months ago
—
6 months old
Consider converting this for loop into a for-each loop
547 tokens.add(token);
548 }
549 } else {
550 for (int i = 0; i < children.size(); i++) {551 children.get(i).getTokens(tokens);
552 }
553 }Consider converting this for loop into a for-each loop
128 ArrayList<String> getParameterNames() {
129 var parameterNames = new ArrayList<String>(parameterList.size());
130 if (isFunctionLikeMacro()) {
131 for (int i = 0; i < parameterList.size(); i++) {132 parameterNames.add(parameterList.get(i).getValue());
133 }
134 }Consider converting this for loop into a for-each loop
96 */
97 static List<Token> markAllAsGenerated(List<Token> tokens) {
98 var result = new ArrayList<Token>(tokens.size());
99 for (int i = 0; i < tokens.size(); i++) {100 result.add(PPGeneratedToken.build(tokens.get(i)));
101 }
102 return result;Consider converting this for loop into a for-each loop
37 private static String concatenateStringLiterals(List<Token> concatenatedTokens) {
38 var sb = new StringBuilder(256);
39 sb.append("\"");
40 for (int i = 0; i < concatenatedTokens.size(); i++) {41 sb.append(stripQuotes(concatenatedTokens.get(i).getValue()));
42 }
43 sb.append("\"");Consider converting this for loop into a for-each loop
112 }
113
114 private void transformFileList(String baseDir, String stylesheet, List<File> inputs, String outputs) {
115 for (var j = 0; j < inputs.size(); j++) {116 try {
117 var inputStream = this.getClass().getResourceAsStream("/xsl/" + stylesheet);
118 Source stylesheetFile;
Description
If a for loop can be converted to a foreach loop, consider doing so, as it is a more concise and readable syntax.
This issue is raised when the Java analyzer detects that all elements of a list/array are being iterated over, in sequence, and only one element of the iterable is accessed in one loop iteration.
Bad Practice
for (int i = 0; i < list.size(); i++) {
SomeType value = list.get(i);
// do whatever is required with value.
}
Recommended
Use the foreach syntax to iterate over the iterable instead.
for (SomeType value : list) {
// Do the required operation.
}