Unnecessary
None provided as default PTC-W0039
Anti-pattern
Minor
6 months ago
—
3 years old
None as default value is redundant332 cdata = CDATA(description)
333 et.SubElement(rule, 'description').append(cdata)
334
335 custom_severity = SEVERITY_MAP.get(key, None)336 if custom_severity:
337 default_issue_severity = custom_severity["severity"]
338 default_issue_type = custom_severity["type"]None as default value is redundant 38
39
40def message_with_cwe_reference(msg, cwe_nr):
41 cwe_msg = CWE_MAP.get(str(cwe_nr), None) 42 if cwe_msg is None:
43 sys.stderr.write('CWE ID ' + cwe_nr + ' was not found!\n')
44 href_text = "CWE-{}".format(
Description
It is unnecessary to provide None as the default value when the key is not present in the dictionary as get implicitly returns None.
Not preferred:
value = some_dict.get("key", None)
Preferred:
value = some_dict.get("key")