Unnecessary
elif / else block after continue PYL-R1724
Style
Major
6 months ago
—
a year old
Unnecessary "else" after "continue", remove the "else" and de-indent the code inside it
284 return False # partly
285 token = tokens[-1]
286 if token != expression:
287 if expression in self.rules:288 branch.append(expression)
289 if not self.__match_sequences(branch, self.rules[expression], tokens):
290 branch.pop()
Description
The use of else or elif becomes redundant and can be dropped if the last statement under the leading if / elif block is a continue statement.
In the case of an elif after continue, it can be written as a separate if block.
For else blocks after continue, the statements can be shifted out of else. Please refer to the examples below for reference.
Refactoring the code this way can improve code-readability and make it easier to maintain.
Bad practice
def classify_number(x):
for num in range(x):
if x % 2 == 0:
continue
else:
print(f"{num} is Odd}")
Preferred:
def classify_number(x):
for num in range(x):
if x % 2 == 0:
continue
print(f"{num} is Odd}")