Protected member accessed from outside the class PYL-W0212
Bug risk
Minor
5 months ago
—
3 years old
Access to a protected member _serialize of a client class
83if sys.version_info[0] > 2:
84 et._serialize_xml = et._serialize['xml'] = _serialize_xml_3
85else:
86 et._serialize_xml = et._serialize['xml'] = _serialize_xml_2 87
88
89def get_cdata_capable_xml_etree():Access to a protected member _serialize_xml of a client class
83if sys.version_info[0] > 2:
84 et._serialize_xml = et._serialize['xml'] = _serialize_xml_3
85else:
86 et._serialize_xml = et._serialize['xml'] = _serialize_xml_2 87
88
89def get_cdata_capable_xml_etree():Access to a protected member _serialize of a client class
81
82
83if sys.version_info[0] > 2:
84 et._serialize_xml = et._serialize['xml'] = _serialize_xml_3 85else:
86 et._serialize_xml = et._serialize['xml'] = _serialize_xml_2
87Access to a protected member _serialize_xml of a client class
81
82
83if sys.version_info[0] > 2:
84 et._serialize_xml = et._serialize['xml'] = _serialize_xml_3 85else:
86 et._serialize_xml = et._serialize['xml'] = _serialize_xml_2
87Access to a protected member _original_serialize_xml of a client class
77 write(("<%s%s]]>%s" % (elem.tag, elem.text.encode('ascii', 'ignore').decode('utf-8'), tail)))
78
79 else:
80 et._original_serialize_xml(write, elem, qnames, namespaces, short_empty_elements) 81
82
83if sys.version_info[0] > 2:
Description
Accessing a protected member (a member prefixed with _) of a class from outside that class is not recommended, since the creator of that class did not intend this member to be exposed. If accesing this attribute outside of the class is absolutely needed, refactor it such that it becomes part of the public interface of the class.
Bad practice
class Rectangle(object):
def __init__(self, height, width):
self._height = height
self._width = width
r = Rectangle(4, 8)
area = r._height * r._width
Preferred:
class Rectangle(object):
def __init__(self, height, width):
self._height = height
self._width = width
def area():
return self._height * self._width
r = Rectangle(4, 8)
area = r.area()