Unused variable found PYL-W0612
Anti-pattern
Major
5 months ago
—
3 years old
Unused variable 'name'
383 rule = et.Element('rule')
384 et.SubElement(rule, 'key').text = rule_key
385 et.SubElement(rule, 'cardinality').text = "MULTIPLE"
386 name = et.SubElement(rule, 'name').text=rule_name387 et.SubElement(rule, 'description').append(CDATA(rule_description))
388 et.SubElement(rule, 'severity').text = rule_severity
389 rules.append(rule)Unused variable 'name'
292 _, clang_tidy_rules = parse_rules_xml(clang_tidy_xml)
293 _, clang_diagnostic_rules = parse_rules_xml(clang_diagnostic_xml)
294 merged_rules = et.Element('rules')
295 for name, clang_tidy_rule in clang_tidy_rules.items():296 rule_tag = clang_tidy_rule
297 indent(rule_tag)
298 make_rules_description_to_cdata(rule_tag)
Description
An unused variable takes up space in the code, and can lead to confusion, and it should be removed. If this variable is necessary, name the variable _ to indicate that it will be unused, or start the name with unused or _unused.
Bad practice
def update():
for i in range(10): # Usused variable `i`
time.sleep(0.01)
display_result()
Preferred:
def update():
for _ in range(10):
time.sleep(0.01)
display_result()