Re-definition found for builtin function PYL-W0622
Anti-pattern
Major
5 months ago
—
3 years old
Redefining built-in 'input'
301 self.__log_branch(" |- reduced: %s", branch, sequence)
302 return True # reduce
303
304 def match(self, input):305 """
306 Searches for rules that match given input tokens.
307 """Redefining built-in 'type'
109
110 severity = elems[2].replace("\"", "")
111 id = elems[3].replace("\"", "") + "." + elems[4].replace("\"", "")
112 type = elems[5].replace("\"", "").strip()113 description = elems[6].replace("\"", "")
114 function = elems[7].replace("\"", "")
115 module =elems[8].replace("\"", "")
Description
Defining a local variable or function with the same name as a built-in object makes the built-in object unusable within the current scope and makes the code prone to bugs.
Bad practice
dict = {} # dict is a Python builtin!
for idx, student in enumerate(students):
dict[student] = idx
Preferred:
roll_number = {}
for idx, student in enumerate(students):
roll_number[student] = idx