JS-0239 · Consider using `let` or `const` instead of `var`

Consider using let or const instead of var JS-0239

Anti-pattern

Major

20 days ago — 2 years old

Unexpected var, use let or const instead

16    }
17    var valid = (dbq.email == body.email) && (dbq.password == body.password);
18    if (valid) {
19        var token = uuidv4();20        redis.set(`${process.env.UPSTASH_REDIS_BASEKEY}:auth:sessions:${token}`, `${process.env.UPSTASH_REDIS_BASEKEY}:users:users:${dbq.email}`, {
21            ex: 604800
22        });

Unexpected var, use let or const instead

pages/api/auth/sign-in.js

14        res.redirect(302, "/sign-in?error=Internal");
15        return;
16    }
17    var valid = (dbq.email == body.email) && (dbq.password == body.password);18    if (valid) {
19        var token = uuidv4();
20        redis.set(`${process.env.UPSTASH_REDIS_BASEKEY}:auth:sessions:${token}`, `${process.env.UPSTASH_REDIS_BASEKEY}:users:users:${dbq.email}`, {

Unexpected var, use let or const instead

pages/api/auth/sign-in.js

 9        url: process.env.UPSTASH_REDIS_URL,
10        token: process.env.UPSTASH_REDIS_TOKEN
11    });
12    var dbq = await redis.get(`${process.env.UPSTASH_REDIS_BASEKEY}:users:users:${body.email}`);13    if (!dbq.email || !dbq.password) {
14        res.redirect(302, "/sign-in?error=Internal");
15        return;

Description

It is recommended to use let or const over var. This will help prevent re-declaration of variables that are in the global scope when using var.

ES6 allows programmers to create variables with block scope instead of function scope using the let and const keywords. Block scope is common in many other programming languages and helps programmers avoid mistakes such as this one:

var count = people.length;
var enoughFood = count > sandwiches.length;

if (enoughFood) {
    var count = sandwiches.length; // accidentally overriding the count variable
    console.log("We have " + count + " sandwiches for everyone. Plenty for all!");
}

// our count variable is no longer accurate
console.log("We have " + count + " people and " + sandwiches.length + " sandwiches!");

Block scoped variables shadow outer declarations instead of writing to them.

NOTE: There are certain edge cases where users might want to consider var. Consider this example:

var lib = lib || { run: () => {} }

Here, lib might be a library that is exposed to an HTML file using a <script> tag. The var keyword helps avoid re-writing lib if it has already been declared via an injected script that was executed before this one. Ideally, you should let bundlers worry about cases like this. But if you want to use var anyway, consider using a skipcq comment, or disabling the issue altogether.

Bad Practice

var x = "y";
var CONFIG = {};

Spelunking-Studios / The-Caverns-Website

Bad Practice

Recommended