Require template literals instead of string concatenation JS-0246
Anti-pattern
Minor
19 days ago
—
2 years old
Unexpected string concatenation
14export default function enemyStats(props) {
15 const router = useRouter();
16 const enemy = router.query.enemy;
17 const { data, error } = useSWR('/api/game-info/enemy-stats/' + enemy, fetcher);18 if (!enemy) {
19 return (
20 <div>Not found</div>Unexpected string concatenation
68 </fieldset>
69 <fieldset className="grid grid-cols-3 lg:grid-cols-4 p-2 mx-auto">
70 <label className="text-xl lg:text-2xl my-auto p-1">Category</label>
71 <div id="dropdown" class={`relative ${dropdownStyles.dropdown} bg-zinc-300 dark:bg-zinc-600 rounded-lg px-3 dark:text-gray-200 dark:text-zinc-300 text-neutral-700 col-span-2 lg:col-span-3 p-0`} active={"" + dropdownActive}>72 <p className="text-lg transition ease-in-out duration-100 p-1 leading-loose hover:cursor-pointer select-none rounded-none" onClick={dropdownClick}>{category}</p>
73 <ul className="grid grid-col-1 py-1 text-sm bg-zinc-300 dark:bg-zinc-600 rounded-b-lg pr-5 pl-3 dark:text-gray-200 dark:text-neutral-300 text-neutral-700 w-full max-h-32 overflow-y-auto mx-auto" aria-labelledby="dropdownMenu">
74 <p className="text-lg transition ease-in-out duration-100 p-1 hover:text-sky-500 dark:hover:text-sky-400 leading-loose hover:cursor-pointer" onClick={dropdownClickBug}>Bug</p>Unexpected string concatenation
5 const enemyName = req.query.enemy;
6 const directory = path.join(process.cwd(), 'public/images/enemies');
7 try {
8 const imageBuffer = await fs.readFile(directory + `/${enemyName}.png`); 9 res.setHeader('Content-Type', 'image/png');
10 res.status(200);
11 res.send(imageBuffer);Unexpected string concatenation
5 const enemyName = req.query.enemy;
6 const jsonDirectory = path.join(process.cwd(), 'enemyData');
7 try {
8 const fileContents = await fs.readFile(jsonDirectory + `/${enemyName}.json`, 'utf8'); 9 res.status(200).json(JSON.parse(JSON.stringify(fileContents)));
10 } catch (err) {
11 res.status(404).json(JSON.stringify({Unexpected string concatenation
4export default async function handler(req, res) {
5 const jsonDirectory = path.join(process.cwd(), 'enemyData');
6 try {
7 const fileContents = await fs.readFile(jsonDirectory + `/enemies.json`, 'utf8'); 8 res.status(200).json(JSON.parse(JSON.stringify(fileContents)));
9 } catch (err) {
10 res.status(404).json(JSON.stringify({
Description
In ES2015 (ES6), we can use template literals instead of string concatenation.
var str = `Hello, ${name}!`;
Bad Practice
var str = "Hello, " + name + "!";
var str = "Time: " + (12 * 60 * 60 * 1000);
Recommended
var str = "Hello World!";
var str = `Hello, ${name}!`;
var str = `Time: ${12 * 60 * 60 * 1000}`;
var str = "Hello, " + "World!";