Found redundant return statement JS-W1045
Anti-pattern
Minor
19 days ago
—
19 days old
This return statement can be removed
28 return;
29 } else {
30 res.redirect(302, "/sign-in?error=BadInfo");
31 return;32 }
33}This return statement can be removed
25 maxAge: 604800
26 });
27 res.redirect(302, "/");
28 return;29 } else {
30 res.redirect(302, "/sign-in?error=BadInfo");
31 return;
Description
Return statements are unnecessary if the control flow will naturally exit a function.
Bad Practice
function writeToFile(file: string, content: string) {
if (fileExists(file)) {
fs.writeFileSync(file, content)
return // <-- this is not necessary
}
}
Recommended
function writeToFile(file: string, content: string) {
if (fileExists(file)) {
fs.writeFileSync(file, content);
}