Found no return statements in callbacks of array methods JS-0042
Anti-pattern
Major
5 months ago
—
3 years old
Array.prototype.some() expects a value to be returned at the end of arrow function
549 const mbed = new Discord.MessageEmbed()
550 .setColor(6765239)
551 .setTitle("Spell Check");
552 items.some(({ fragment, suggestions }) => {553 let addition = `~~${fragment}~~ → **${suggestions.join("**, **") || "No suggestions"} **\n`;
554 if (desc.length + addition.length > 2000) {
555 mbed.setFooter("This spellcheck has been shortened.");
Description
Array has several methods for filtering, mapping, and folding.
If we forget to write return statement in a callback of those, it's probably a mistake.
If you don't want to use a return or don't need the returned results, consider using .forEach instead.
Bad Practice
const indexMap = myArray.reduce(function(memo, item, index) {
memo[item] = index;
}, {});
const foo = Array.from(nodes, function(node) {
if (node.tagName === "DIV") {
return true;
}
});
const bar = foo.filter(function(x) {
if (x) {
return true;
} else {
return;
}
});
Recommended
const indexMap = myArray.reduce(function(memo, item, index) {
memo[item] = index;
return memo;
}, {});
const foo = Array.from(nodes, function(node) {
if (node.tagName === "DIV") {
return true;
}
return false;
});
const bar = foo.map(node => node.getAttribute("id"));