Consider using arrow functions for callbacks JS-0241
Anti-pattern
Minor
5 months ago
—
5 months old
Unexpected function expression
10 db.each("SELECT * FROM Quotes ORDER BY id DESC limit 1;", function (error, row) {
11 if (error) { console.error(error) }
12 db.run(`INSERT INTO Quotes(quote, id, source, usage) VALUES(?,?,?,?)`,
13 [qt, row.id + 1, src, 0], function (error) {14 if (error) { console.error(error) }15 else { console.log("Added quote!") }16 }17 );//SELECT * FROM Quotes ORDER BY id ASC limit 1;
18 rl.close();
19 });Unexpected function expression
7});
8rl.question("What is the quote? ", function (qt) {
9 rl.question("Who wrote it? ", function (src) {
10 db.each("SELECT * FROM Quotes ORDER BY id DESC limit 1;", function (error, row) {11 if (error) { console.error(error) }12 db.run(`INSERT INTO Quotes(quote, id, source, usage) VALUES(?,?,?,?)`,13 [qt, row.id + 1, src, 0], function (error) {14 if (error) { console.error(error) }15 else { console.log("Added quote!") }16 }17 );//SELECT * FROM Quotes ORDER BY id ASC limit 1;18 rl.close();19 });20 });
21});Unexpected function expression
6 output: process.stdout
7});
8rl.question("What is the quote? ", function (qt) {
9 rl.question("Who wrote it? ", function (src) {10 db.each("SELECT * FROM Quotes ORDER BY id DESC limit 1;", function (error, row) {11 if (error) { console.error(error) }12 db.run(`INSERT INTO Quotes(quote, id, source, usage) VALUES(?,?,?,?)`,13 [qt, row.id + 1, src, 0], function (error) {14 if (error) { console.error(error) }15 else { console.log("Added quote!") }16 }17 );//SELECT * FROM Quotes ORDER BY id ASC limit 1;18 rl.close();19 });20 });21});Unexpected function expression
5 input: process.stdin,
6 output: process.stdout
7});
8rl.question("What is the quote? ", function (qt) { 9 rl.question("Who wrote it? ", function (src) {10 db.each("SELECT * FROM Quotes ORDER BY id DESC limit 1;", function (error, row) {11 if (error) { console.error(error) }12 db.run(`INSERT INTO Quotes(quote, id, source, usage) VALUES(?,?,?,?)`,13 [qt, row.id + 1, src, 0], function (error) {14 if (error) { console.error(error) }15 else { console.log("Added quote!") }16 }17 );//SELECT * FROM Quotes ORDER BY id ASC limit 1;18 rl.close();19 });20 });21});
Description
It is recommended to use arrow functions as callbacks.
Arrow functions can be an attractive alternative to function expressions for callbacks or function arguments.
For example, arrow functions are automatically bound to their surrounding scope/context. This provides an alternative to the pre-ES6 standard of explicitly binding function expressions to achieve similar behavior.
Additionally, arrow functions are:
less verbose, and easier to reason about.
bound lexically regardless of where or when they are invoked.
Bad Practice
func(function(a) { return a; }); // ERROR
// prefer: func(a => a)
func(function() { return this.a; }.bind(this)); // ERROR
// prefer: func(() => this.a)
Recommended
// arrow function callback
func(a => a); // OK
// generator as callback
func(function*() { yield; }); // OK
// function expression not used as callback or function argument
var funcVar = function func(a) { return a; }; // OK
// unbound function expression callback
func(function() { return this.a; }); // OK
// recursive named function callback
func(function recursiveFunc(n) { return n && n + recursiveFunc(n - 1); }); // OK