Found trailing undefined in function call JS-W1042
Anti-pattern
Minor
5 months ago
—
5 months old
Remove redundant
undefined from function call431 return null;
432 } else if (stockData.error ||
433 (Object.keys(stockData).length == 0 && stockData.constructor === Object) ||
434 Object.values(stockData).includes(undefined) ||435 stockData.t === 0) {
436 message.reply(embed.error(`${args[0]} was not found.`, (stockData.error || "ERR_ALLSTOCK_ZERO")));
437 return null;
Description
When an argument is omitted from a function call, it will default to undefined.
It is therefore redundant to explicitly pass an undefined literal as the last argument.
Bad Practice
function hasOptionalParam(a: number, b?: number) {
// ...
}
hasOptionalParam(1, undefined)
Recommended
function hasOptionalParam(a: number, b?: number) {
// ...
}
hasOptionalParam(1)
hasOptionalParam(1, 2)