switch statements with only 2 branches should be if statements instead JAVA-W1086
Anti-pattern
Major
9 months ago
—
9 months old
This switch could be an if statement
92 }
93
94 final String name;
95 switch (parameter.getType().getSimpleName()) { 96 case "Island":
97 name = "slot";
98 break;
Description
switch statements that have only two arms can be better represented as if statements.
If the intent is to add more cases later on, consider adding a // skipcq: JAVA-W1086 to
the top of the switch block to avoid reporting the issue.
Bad Practice
switch (someInt) {
case 1 -> action1();
default -> elseAction();
}
Recommended
Just use an if-else block:
if (someInt == 1) {
action1();
} else {
elseAction();
}
Exceptions
This issue will not be reported for switch blocks that have multiple non-default arms.