All issues PYL-R1705

Unnecessary

`else`

/ `elif`

used after `return`

PYL-R1705
Style

7 months ago
—
7 months old

Unnecessary "else" after "return", remove the "else" and de-indent the code inside it

```
76
77@app.get("/")
78def index():
79 if os.path.exists("./web/index.html"): 80 return FileResponse(
81 "web/index.html",
82 200
```

Description

The use of `else`

or `elif`

becomes redundant and can be dropped if the last statement under the leading `if`

/ `elif`

block is a `return`

statement.
In the case of an `elif`

after `return`

, it can be written as a separate `if`

block.
For `else`

blocks after `return`

, the statements can be shifted out of `else`

. Please refer to the examples below for reference.

Refactoring the code this way can improve code-readability and make it easier to maintain.

```
def classify_number(x):
if x % 2 == 0:
return 'Even'
else:
return 'Odd'
def what_is_this_number(x):
if x % 2 == 0 and x >= 0:
return 'Even'
elif x % 2 == 0 and x < 0:
return 'Even and Negative'
elif x % 2 != 0 and x < 0:
return 'Odd and Negative.'
else:
return 'Odd'
```

```
def classify_number(x):
if x % 2 == 0:
return 'Even'
return 'Odd'
def what_is_this_number(x):
if x % 2 == 0 and x >= 0:
return 'Even'
if x % 2 == 0 and x < 0:
return 'Even and Negative'
if x % 2 != 0 and x < 0:
return 'Odd and Negative'
return 'Odd'
```