Found unused objects JS-R1002
Anti-pattern
2 months ago
—
2 months old
Avoid instantiating unused object 'new bootstrap.Tooltip(tooltip)'.
66function ekiline_collection_js_init_popovers(){
67 document.querySelectorAll('[data-bs-toggle="tooltip"]')
68 .forEach(function (tooltip) {
69 new bootstrap.Tooltip(tooltip); 70 });
71
72 document.querySelectorAll('[data-bs-toggle="popover"]')Avoid instantiating unused object 'new bootstrap.Popover(popover)'.
71
72 document.querySelectorAll('[data-bs-toggle="popover"]')
73 .forEach(function (popover) {
74 new bootstrap.Popover(popover); 75 });
76}
77ekiline_collection_js_init_popovers();
Description
Class constructors being invoked and then dropped immediately is an anti-pattern and should be avoided.
Objects instantiated with new should always be useful in some way (passed as a function argument, stored in a variable for later use, etc).
If the object is instantiated only to invoke some side effect in the constructor, then the side effect should be refactored out into it's own function.
Bad Practice
new Foo()
Recommended
const myFoo = new Foo()