Exceptions are overlapping PYL-W0714
Anti-pattern
Major
3 months ago
—
3 months old
Overlapping exceptions (ImportError is an ancestor class of ModuleNotFoundError)
259 """ import custom modules dynamically """
260 try:
261 return importlib.import_module(req_module)
262 except (ModuleNotFoundError, ImportError):263 if re_raise:
264 raise
265
Description
Two or more exceptions in the same exception handler clause that are identical or parts of the same inheritance hierarchy (i.e. overlapping). It is recommmend to refactor this.
Not preferred:
class SomeException(Exception):
pass
class SubclassException(SomeException):
pass
try:
raise SubclassException()
except (SomeException, SubclassException):
pass
Here, SubclassException has been derived from SomeException, which makes it overlapping.
Preferred:
class SomeException(Exception):
pass
class SubclassException(SomeException):
pass
try:
raise SubclassException()
except SomeException:
pass