if statements can be merged PTC-W0048
Anti-pattern
Major
a year ago
—
a year old
Consider merging collapsible if statements
245
246 def check_hover(self, x, y):
247 # check if the mouse is hovering over the scroll view
248 if self.x <= x <= self.x + self.width:249 if self.y <= y <= self.y + self.display_height:
250 return True
251 return FalseConsider merging collapsible if statements
245
246 def check_hover(self, x, y):
247 # check if the mouse is hovering over the scroll view
248 if self.x <= x <= self.x + self.width:249 if self.y <= y <= self.y + self.display_height:
250 return True
251 return False
Description
Nested if statements can be collapsed into a single if statement by separating their condition using and operator.
Merging collapsible if statements increases the code's readability.
Bad practice
if condition1:
if condition2:
dosomething()
Preferred
if condition1 and condition2:
dosomething()
Exception:
DeepSource will not raise this issue when the nested if statements have comments in between them, as it could be explaining why the nested if is in place.