Implicit enumerate calls found PTC-W0060
Anti-pattern
Major
a year ago
—
a year old
Consider replacing
range(len(self.ez_textFields)) with enumerate(self.ez_textFields)120 self.toggleMouse = not self.toggleMouse
121 self.app.fractal.reset()
122 if not self.toggleMouse:
123 for i in range(len(self.ez_textFields)):124 self.update_text_fields(i, self.ez_textFields[i].value)
125 if checked_ez_toggle.name == "toggleFPS":
126 self.toggleFPS = not self.toggleFPSConsider replacing
range(len(self.ez_textFields)) with enumerate(self.ez_textFields)158 # check reset key
159 if key == "r":
160 self.app.fractal.reset()
161 for i in range(len(self.ez_textFields)):162 self.update_text_fields(i, self.ez_textFields[i].value)
163 if self.toggleMandelbrot:
164 self.app.fractal.offset[0] += 75Consider replacing
range(len(self.ez_textFields)) with enumerate(self.ez_textFields)158 # check reset key
159 if key == "r":
160 self.app.fractal.reset()
161 for i in range(len(self.ez_textFields)):162 self.update_text_fields(i, self.ez_textFields[i].value)
163 if self.toggleMandelbrot:
164 self.app.fractal.offset[0] += 75Consider replacing
range(len(self.ez_textFields)) with enumerate(self.ez_textFields)120 self.toggleMouse = not self.toggleMouse
121 self.app.fractal.reset()
122 if not self.toggleMouse:
123 for i in range(len(self.ez_textFields)):124 self.update_text_fields(i, self.ez_textFields[i].value)
125 if checked_ez_toggle.name == "toggleFPS":
126 self.toggleFPS = not self.toggleFPS
Description
Using range(len(...)) is not pythonic. Python does not have not index-based loops. Instead, it uses collection iterators.
Python has a built-in method enumerate which adds a counter to an iterable.
Using this, you can access the counter and the value from the iterable at the same time.
It is therefore recommended to replace range(len(...)) with enumerate(...).
Not Preferred:
for index in range(len(mylist)):
...
Preferred:
for index, element in enumerate(mylist):
...