Sequence value overwritten unconditionally PTC-W0057
Anti-pattern
Major
6 months ago
—
3 years old
The next statement overwrites the value at collection unconditionally.
166
167 else:
168 # prevent hanging on weird requests
169 self.env['REQUEST_METHOD'] = 'GET'170 self.env['REQUEST_METHOD'] = self.method
171
172 self.url_cgi_query = cgi.FieldStorage(
Description
You are assigning values at the same sequence index continuously without performing any other operations between them. This might be something that was not intended and we suggest you retake a look at it. If you want the value of the later assignment to be stored, it is recommended to remove this assignment, since it is anyways going to be overwritten.
Not preferred:
some_numbers = [1, 2, 3, 4, 5]
some_numbers[0] = 3
some_numbers[0] = 4 # unconditionally overwritting the existing value
mymap = {'one': 1, 'two': 2}
mymap['one'] = 4
mymap['one'] = 3 # unconditionally overwritting value mapped to `one`
Preferred:
some_numbers = [1, 2, 3, 4, 5]
some_numbers[0] = 3
check_some_numbers()
some_numbers[0] = 4
mymap = {'one': 1, 'two': 2}
mymap['one'] = 4
if condition:
mymap['one'] = 3