Protected member accessed from outside the class PYL-W0212
Bug risk
Minor
6 months ago
—
4 years old
Access to a protected member _reader of a client class
75
76 def send(self, obj):
77 rq = GateStreamRequest(obj, self)
78 if not self.pipe._reader._closed: 79 for part in _seq_split(json.dumps(rq.serialize())):
80 self.pipe.put(part)
81 if self.log:Access to a protected member _closed of a client class
75
76 def send(self, obj):
77 rq = GateStreamRequest(obj, self)
78 if not self.pipe._reader._closed: 79 for part in _seq_split(json.dumps(rq.serialize())):
80 self.pipe.put(part)
81 if self.log:
Description
Accessing a protected member (a member prefixed with _) of a class from outside that class is not recommended, since the creator of that class did not intend this member to be exposed. If accesing this attribute outside of the class is absolutely needed, refactor it such that it becomes part of the public interface of the class.
Bad practice
class Rectangle(object):
def __init__(self, height, width):
self._height = height
self._width = width
r = Rectangle(4, 8)
area = r._height * r._width
Preferred:
class Rectangle(object):
def __init__(self, height, width):
self._height = height
self._width = width
def area():
return self._height * self._width
r = Rectangle(4, 8)
area = r.area()