Exit inside non-main function RVV-A0003
Anti-pattern
Major
a year ago
—
2 years old
calls to log.Fatal only in main() or init() functions
10func NewSqliteConnection(dbPath string) *sql.DB {
11 db, err := sql.Open("sqlite3", dbPath)
12 if err != nil {
13 log.Fatal(err)14 }
15 return db
16}
Description
Packages exposing functions that can stop program execution by exiting are hard to reuse. Program exits in functions other than main() or init() are not encouraged.
Bad practice
func nonMainFunc() {
safelyExit := true // somehow arrive at this value
if safelyExit {
os.Exit(0)
}
}
func main() {
nonMainFunc()
}
Recommended
func nonMainFunc() bool {
safelyExit := true // somehow arrive at this value
}
func main() {
safelyExit := nonMainFunc()
if safelyExit {
os.Exit(0)
}
}