Value assigned to a variable is never read before being overwritten SCC-SA4006
Bug risk
Critical
a year ago
—
2 years old
this value of err is never used
34 panic(err)
35 }
36
37 body, err := ioutil.ReadAll(res.Body)38
39 var responseTeleFile FileIdRequest
40 err = json.Unmarshal(body, &responseTeleFile)this value of err is never used
23 err = os.Mkdir(homePath, os.ModePerm)
24
25 execCmd := new(executor.CommandOutputWriter)
26 _, outErr, err := execCmd.ExecFullOutput(fmt.Sprintf("wget https://github.com/alfiankan/teleterm/raw/main/empty/teleterm.db -P %s", homePath))27 _, outErr, err = execCmd.ExecFullOutput(fmt.Sprintf("wget https://github.com/alfiankan/teleterm/raw/main/empty/config.yaml -P %s", homePath))
28 if err != nil {
29 fmt.Println(outErr)this value of outErr is never used
23 err = os.Mkdir(homePath, os.ModePerm)
24
25 execCmd := new(executor.CommandOutputWriter)
26 _, outErr, err := execCmd.ExecFullOutput(fmt.Sprintf("wget https://github.com/alfiankan/teleterm/raw/main/empty/teleterm.db -P %s", homePath))27 _, outErr, err = execCmd.ExecFullOutput(fmt.Sprintf("wget https://github.com/alfiankan/teleterm/raw/main/empty/config.yaml -P %s", homePath))
28 if err != nil {
29 fmt.Println(outErr)this value of err is never used
19 // reconfigure
20 fmt.Println("Fresh Configuring, Please Wait ...")
21 homePath := fmt.Sprintf("%s/.teleterm", os.Getenv("HOME"))
22 err := os.RemoveAll(homePath)23 err = os.Mkdir(homePath, os.ModePerm)
24
25 execCmd := new(executor.CommandOutputWriter)this value of err is never used
20 fmt.Println("Fresh Configuring, Please Wait ...")
21 homePath := fmt.Sprintf("%s/.teleterm", os.Getenv("HOME"))
22 err := os.RemoveAll(homePath)
23 err = os.Mkdir(homePath, os.ModePerm)24
25 execCmd := new(executor.CommandOutputWriter)
26 _, outErr, err := execCmd.ExecFullOutput(fmt.Sprintf("wget https://github.com/alfiankan/teleterm/raw/main/empty/teleterm.db -P %s", homePath))
Description
Value has been assigned to a variable, but it is being overwritten before being read. In most cases, this could be a forgotten error check or dead code.
Bad practice
err := Op1()
// error value assigned to "err" by "Op1" is replaced with
// error value assigned by "Op2" before even being read even
// once
err = Op2()
if err != nil {
return err
}
Recommended
// Ignore the error value returned by "Op1"
Op1()
err := Op2()
if err != nil {
return err
}
err := Op1()
// Read the error value assigned to "err" by "Op1"
if err != nil {
return err
}
err = Op2()
if err != nil {
return err
}