PYL-W0201 · Attribute defined outside `__init_

anton-hk / translator

Active

Attribute defined outside __init__ PYL-W0201

Anti-pattern

Minor

2 years ago — 2 years old

Attribute 'statusbar' defined outside __init__

 95        self.comboBox_2.setGeometry(QRect(130, 220, 171, 21))
 96        self.comboBox_2.setCurrentIndex(15)
 97        Dialoge.setCentralWidget(self.centralwidget)
 98        self.statusbar = QStatusBar(Dialoge) 99        self.statusbar.setObjectName(u"statusbar")
100        Dialoge.setStatusBar(self.statusbar)
101

Attribute 'comboBox_2' defined outside __init__

tran1_gui.py

 70        self.label_2 = QLabel(self.centralwidget)
 71        self.label_2.setObjectName(u"label_2")
 72        self.label_2.setGeometry(QRect(30, 30, 91, 21))
 73        self.comboBox_2 = QComboBox(self.centralwidget) 74        self.comboBox_2.addItem("")
 75        self.comboBox_2.addItem("")
 76        self.comboBox_2.addItem("")

Attribute 'label_2' defined outside __init__

tran1_gui.py

 67        self.textBrowser.setObjectName(u"textBrowser")
 68        self.textBrowser.setGeometry(QRect(30, 290, 751, 141))
 69        self.textBrowser.setFont(font)
 70        self.label_2 = QLabel(self.centralwidget) 71        self.label_2.setObjectName(u"label_2")
 72        self.label_2.setGeometry(QRect(30, 30, 91, 21))
 73        self.comboBox_2 = QComboBox(self.centralwidget)

Attribute 'textBrowser' defined outside __init__

tran1_gui.py

 63        self.label_3 = QLabel(self.centralwidget)
 64        self.label_3.setObjectName(u"label_3")
 65        self.label_3.setGeometry(QRect(30, 220, 91, 21))
 66        self.textBrowser = QTextBrowser(self.centralwidget) 67        self.textBrowser.setObjectName(u"textBrowser")
 68        self.textBrowser.setGeometry(QRect(30, 290, 751, 141))
 69        self.textBrowser.setFont(font)

Attribute 'label_3' defined outside __init__

tran1_gui.py

 60        self.pushButton = QPushButton(self.centralwidget)
 61        self.pushButton.setObjectName(u"pushButton")
 62        self.pushButton.setGeometry(QRect(642, 230, 111, 28))
 63        self.label_3 = QLabel(self.centralwidget) 64        self.label_3.setObjectName(u"label_3")
 65        self.label_3.setGeometry(QRect(30, 220, 91, 21))
 66        self.textBrowser = QTextBrowser(self.centralwidget)

Description

Defining an instance attribute outside __init__ affects the readability of code. It is expected to find all the attributes an instance may have by reading its __init__ method. If there is a need to initialize attribute via sub-initialization methods, it is recommended to assign attributes to None in the init then call the sub-initialization methods.