PY-W2000 @ 04bd3f4 • anton-hk / translator

Run summary

a year ago

4fade26..04bd3f4

15 s

Imported name is not used anywhere in the module PY-W2000

Anti-pattern

Major

21 occurrences in this check

Unused QRadialGradient imported from PySide2.QtGui

tran1_gui.py

 10
 11from PySide2.QtCore import (QCoreApplication, QDate, QDateTime, QMetaObject,
 12    QObject, QPoint, QRect, QSize, QTime, QUrl, Qt)
 13from PySide2.QtGui import (QBrush, QColor, QConicalGradient, QCursor, QFont, 14    QFontDatabase, QIcon, QKeySequence, QLinearGradient, QPalette, QPainter,
 15    QPixmap, QRadialGradient)
 16from PySide2.QtWidgets import *

Unused QPixmap imported from PySide2.QtGui

tran1_gui.py

 10
 11from PySide2.QtCore import (QCoreApplication, QDate, QDateTime, QMetaObject,
 12    QObject, QPoint, QRect, QSize, QTime, QUrl, Qt)
 13from PySide2.QtGui import (QBrush, QColor, QConicalGradient, QCursor, QFont, 14    QFontDatabase, QIcon, QKeySequence, QLinearGradient, QPalette, QPainter,
 15    QPixmap, QRadialGradient)
 16from PySide2.QtWidgets import *

Unused QPainter imported from PySide2.QtGui

tran1_gui.py

 10
 11from PySide2.QtCore import (QCoreApplication, QDate, QDateTime, QMetaObject,
 12    QObject, QPoint, QRect, QSize, QTime, QUrl, Qt)
 13from PySide2.QtGui import (QBrush, QColor, QConicalGradient, QCursor, QFont, 14    QFontDatabase, QIcon, QKeySequence, QLinearGradient, QPalette, QPainter,
 15    QPixmap, QRadialGradient)
 16from PySide2.QtWidgets import *

Unused QPalette imported from PySide2.QtGui

tran1_gui.py

 10
 11from PySide2.QtCore import (QCoreApplication, QDate, QDateTime, QMetaObject,
 12    QObject, QPoint, QRect, QSize, QTime, QUrl, Qt)
 13from PySide2.QtGui import (QBrush, QColor, QConicalGradient, QCursor, QFont, 14    QFontDatabase, QIcon, QKeySequence, QLinearGradient, QPalette, QPainter,
 15    QPixmap, QRadialGradient)
 16from PySide2.QtWidgets import *

Unused QLinearGradient imported from PySide2.QtGui

tran1_gui.py

 10
 11from PySide2.QtCore import (QCoreApplication, QDate, QDateTime, QMetaObject,
 12    QObject, QPoint, QRect, QSize, QTime, QUrl, Qt)
 13from PySide2.QtGui import (QBrush, QColor, QConicalGradient, QCursor, QFont, 14    QFontDatabase, QIcon, QKeySequence, QLinearGradient, QPalette, QPainter,
 15    QPixmap, QRadialGradient)
 16from PySide2.QtWidgets import *

Unused QKeySequence imported from PySide2.QtGui

tran1_gui.py

 10
 11from PySide2.QtCore import (QCoreApplication, QDate, QDateTime, QMetaObject,
 12    QObject, QPoint, QRect, QSize, QTime, QUrl, Qt)
 13from PySide2.QtGui import (QBrush, QColor, QConicalGradient, QCursor, QFont, 14    QFontDatabase, QIcon, QKeySequence, QLinearGradient, QPalette, QPainter,
 15    QPixmap, QRadialGradient)
 16from PySide2.QtWidgets import *

Unused QIcon imported from PySide2.QtGui

tran1_gui.py

 10
 11from PySide2.QtCore import (QCoreApplication, QDate, QDateTime, QMetaObject,
 12    QObject, QPoint, QRect, QSize, QTime, QUrl, Qt)
 13from PySide2.QtGui import (QBrush, QColor, QConicalGradient, QCursor, QFont, 14    QFontDatabase, QIcon, QKeySequence, QLinearGradient, QPalette, QPainter,
 15    QPixmap, QRadialGradient)
 16from PySide2.QtWidgets import *

Unused QFontDatabase imported from PySide2.QtGui

tran1_gui.py

 10
 11from PySide2.QtCore import (QCoreApplication, QDate, QDateTime, QMetaObject,
 12    QObject, QPoint, QRect, QSize, QTime, QUrl, Qt)
 13from PySide2.QtGui import (QBrush, QColor, QConicalGradient, QCursor, QFont, 14    QFontDatabase, QIcon, QKeySequence, QLinearGradient, QPalette, QPainter,
 15    QPixmap, QRadialGradient)
 16from PySide2.QtWidgets import *

Unused QCursor imported from PySide2.QtGui

tran1_gui.py

 10
 11from PySide2.QtCore import (QCoreApplication, QDate, QDateTime, QMetaObject,
 12    QObject, QPoint, QRect, QSize, QTime, QUrl, Qt)
 13from PySide2.QtGui import (QBrush, QColor, QConicalGradient, QCursor, QFont, 14    QFontDatabase, QIcon, QKeySequence, QLinearGradient, QPalette, QPainter,
 15    QPixmap, QRadialGradient)
 16from PySide2.QtWidgets import *

Unused QConicalGradient imported from PySide2.QtGui

tran1_gui.py

 10
 11from PySide2.QtCore import (QCoreApplication, QDate, QDateTime, QMetaObject,
 12    QObject, QPoint, QRect, QSize, QTime, QUrl, Qt)
 13from PySide2.QtGui import (QBrush, QColor, QConicalGradient, QCursor, QFont, 14    QFontDatabase, QIcon, QKeySequence, QLinearGradient, QPalette, QPainter,
 15    QPixmap, QRadialGradient)
 16from PySide2.QtWidgets import *

Unused QColor imported from PySide2.QtGui

tran1_gui.py

 10
 11from PySide2.QtCore import (QCoreApplication, QDate, QDateTime, QMetaObject,
 12    QObject, QPoint, QRect, QSize, QTime, QUrl, Qt)
 13from PySide2.QtGui import (QBrush, QColor, QConicalGradient, QCursor, QFont, 14    QFontDatabase, QIcon, QKeySequence, QLinearGradient, QPalette, QPainter,
 15    QPixmap, QRadialGradient)
 16from PySide2.QtWidgets import *

Unused QBrush imported from PySide2.QtGui

tran1_gui.py

 10
 11from PySide2.QtCore import (QCoreApplication, QDate, QDateTime, QMetaObject,
 12    QObject, QPoint, QRect, QSize, QTime, QUrl, Qt)
 13from PySide2.QtGui import (QBrush, QColor, QConicalGradient, QCursor, QFont, 14    QFontDatabase, QIcon, QKeySequence, QLinearGradient, QPalette, QPainter,
 15    QPixmap, QRadialGradient)
 16from PySide2.QtWidgets import *

Unused Qt imported from PySide2.QtCore

tran1_gui.py

  8## WARNING! All changes made in this file will be lost when recompiling UI file!
  9################################################################################
 10
 11from PySide2.QtCore import (QCoreApplication, QDate, QDateTime, QMetaObject, 12    QObject, QPoint, QRect, QSize, QTime, QUrl, Qt)
 13from PySide2.QtGui import (QBrush, QColor, QConicalGradient, QCursor, QFont,
 14    QFontDatabase, QIcon, QKeySequence, QLinearGradient, QPalette, QPainter,

Unused QUrl imported from PySide2.QtCore

tran1_gui.py

  8## WARNING! All changes made in this file will be lost when recompiling UI file!
  9################################################################################
 10
 11from PySide2.QtCore import (QCoreApplication, QDate, QDateTime, QMetaObject, 12    QObject, QPoint, QRect, QSize, QTime, QUrl, Qt)
 13from PySide2.QtGui import (QBrush, QColor, QConicalGradient, QCursor, QFont,
 14    QFontDatabase, QIcon, QKeySequence, QLinearGradient, QPalette, QPainter,

Unused QTime imported from PySide2.QtCore

tran1_gui.py

  8## WARNING! All changes made in this file will be lost when recompiling UI file!
  9################################################################################
 10
 11from PySide2.QtCore import (QCoreApplication, QDate, QDateTime, QMetaObject, 12    QObject, QPoint, QRect, QSize, QTime, QUrl, Qt)
 13from PySide2.QtGui import (QBrush, QColor, QConicalGradient, QCursor, QFont,
 14    QFontDatabase, QIcon, QKeySequence, QLinearGradient, QPalette, QPainter,

Unused QPoint imported from PySide2.QtCore

tran1_gui.py

  8## WARNING! All changes made in this file will be lost when recompiling UI file!
  9################################################################################
 10
 11from PySide2.QtCore import (QCoreApplication, QDate, QDateTime, QMetaObject, 12    QObject, QPoint, QRect, QSize, QTime, QUrl, Qt)
 13from PySide2.QtGui import (QBrush, QColor, QConicalGradient, QCursor, QFont,
 14    QFontDatabase, QIcon, QKeySequence, QLinearGradient, QPalette, QPainter,

Unused QObject imported from PySide2.QtCore

tran1_gui.py

  8## WARNING! All changes made in this file will be lost when recompiling UI file!
  9################################################################################
 10
 11from PySide2.QtCore import (QCoreApplication, QDate, QDateTime, QMetaObject, 12    QObject, QPoint, QRect, QSize, QTime, QUrl, Qt)
 13from PySide2.QtGui import (QBrush, QColor, QConicalGradient, QCursor, QFont,
 14    QFontDatabase, QIcon, QKeySequence, QLinearGradient, QPalette, QPainter,

Unused QDateTime imported from PySide2.QtCore

tran1_gui.py

  8## WARNING! All changes made in this file will be lost when recompiling UI file!
  9################################################################################
 10
 11from PySide2.QtCore import (QCoreApplication, QDate, QDateTime, QMetaObject, 12    QObject, QPoint, QRect, QSize, QTime, QUrl, Qt)
 13from PySide2.QtGui import (QBrush, QColor, QConicalGradient, QCursor, QFont,
 14    QFontDatabase, QIcon, QKeySequence, QLinearGradient, QPalette, QPainter,

Unused QDate imported from PySide2.QtCore

tran1_gui.py

  8## WARNING! All changes made in this file will be lost when recompiling UI file!
  9################################################################################
 10
 11from PySide2.QtCore import (QCoreApplication, QDate, QDateTime, QMetaObject, 12    QObject, QPoint, QRect, QSize, QTime, QUrl, Qt)
 13from PySide2.QtGui import (QBrush, QColor, QConicalGradient, QCursor, QFont,
 14    QFontDatabase, QIcon, QKeySequence, QLinearGradient, QPalette, QPainter,

Unused QtCore imported from PySide2

main.py

 1import sys
 2from googletrans import Translator
 3from PySide2 import QtCore, QtGui, QtWidgets 4from uis.tran1_gui import Ui_Dialog
 5
 6

Unused QtGui imported from PySide2

main.py

 1import sys
 2from googletrans import Translator
 3from PySide2 import QtCore, QtGui, QtWidgets 4from uis.tran1_gui import Ui_Dialog
 5
 6

Description

An object has been imported but is not used anywhere in the file. It should either be used or the import should be removed.

Bad practice

import os

def example():
    print("This snippet is not using the `os` import anywhere.")

But this import is used by other modules!

One major reason why this issue can cause confusion is when it's raised for imports that are meant to be exported, for use in other places.

For example, consider this file, mypackage/__init__.py:

from mypackage.foo import is_foo
from mypackage.bar import bar_function

This is a very common pattern to export common functionality from modules, to the top level of a package. But there is a major problem with this approach. Consider this file, mypackage/foo.py:

import os

def is_foo(item):
    return os.path.exists(item)

Since os is imported inside foo.py, you can actually do this:

>>> from mypackage.foo import os

Although weird, Python automatically exports all imports in a file. In practice however, it is ill-advised to rely on this behaviour.

If you want to explicitly export an imported item in a file, add it to the special variable named __all__:

from mypackage.foo import is_foo
from mypackage.bar import bar_function

__all__ = ['is_foo', 'bar_function']  # Notice that these are strings!

DeepSource won't raise an issue if the imported item is present in __all__.

anton-hk / translator

Bad practice

Recommended

But this import is used by other modules!