Require template literals instead of string concatenation JS-0246
Anti-pattern
Minor
6 months ago
—
2 years old
Unexpected string concatenation
2495
2496 for (const patch of thumbs) {
2497 // Manifest patches
2498 thumbsContent = thumbsContent.replace(/\[Hitman5\]\n/gi, "[Hitman5]\n" + patch + "\n")2499 }
2500
2501 fs.writeFileSync(path.join(process.cwd(), "temp", "thumbs.dat.decrypted"), thumbsContent)Unexpected string concatenation
1380 fs.unlinkSync(path.join(process.cwd(), entity.tempHash + ".TEMP.json"))
1381 fs.unlinkSync(path.join(process.cwd(), entity.tempHash + ".TEMP.meta.json"))
1382 fs.unlinkSync(path.join(process.cwd(), entity.tbluHash + ".TBLU.json"))
1383 fs.unlinkSync(path.join(process.cwd(), entity.tbluHash + ".TBLU.meta.json"))1384}
1385
1386module.exports = {Unexpected string concatenation
1379
1380 fs.unlinkSync(path.join(process.cwd(), entity.tempHash + ".TEMP.json"))
1381 fs.unlinkSync(path.join(process.cwd(), entity.tempHash + ".TEMP.meta.json"))
1382 fs.unlinkSync(path.join(process.cwd(), entity.tbluHash + ".TBLU.json"))1383 fs.unlinkSync(path.join(process.cwd(), entity.tbluHash + ".TBLU.meta.json"))
1384}
1385Unexpected string concatenation
1378 await convert(storage.getSync("game"), path.join(process.cwd(), entity.tempHash + ".TEMP.json"), path.join(process.cwd(), entity.tempHash + ".TEMP.meta.json"), path.join(process.cwd(), entity.tbluHash + ".TBLU.json"), path.join(process.cwd(), entity.tbluHash + ".TBLU.meta.json"), automateQNPath)
1379
1380 fs.unlinkSync(path.join(process.cwd(), entity.tempHash + ".TEMP.json"))
1381 fs.unlinkSync(path.join(process.cwd(), entity.tempHash + ".TEMP.meta.json"))1382 fs.unlinkSync(path.join(process.cwd(), entity.tbluHash + ".TBLU.json"))
1383 fs.unlinkSync(path.join(process.cwd(), entity.tbluHash + ".TBLU.meta.json"))
1384}Unexpected string concatenation
1377 await quickentity1136.generate(storage.getSync("game"), automateQNPath, path.join(process.cwd(), entity.tempHash + ".TEMP.json"), path.join(process.cwd(), entity.tempHash + ".TEMP.meta.json"), path.join(process.cwd(), entity.tbluHash + ".TBLU.json"), path.join(process.cwd(), entity.tbluHash + ".TBLU.meta.json"))
1378 await convert(storage.getSync("game"), path.join(process.cwd(), entity.tempHash + ".TEMP.json"), path.join(process.cwd(), entity.tempHash + ".TEMP.meta.json"), path.join(process.cwd(), entity.tbluHash + ".TBLU.json"), path.join(process.cwd(), entity.tbluHash + ".TBLU.meta.json"), automateQNPath)
1379
1380 fs.unlinkSync(path.join(process.cwd(), entity.tempHash + ".TEMP.json"))1381 fs.unlinkSync(path.join(process.cwd(), entity.tempHash + ".TEMP.meta.json"))
1382 fs.unlinkSync(path.join(process.cwd(), entity.tbluHash + ".TBLU.json"))
1383 fs.unlinkSync(path.join(process.cwd(), entity.tbluHash + ".TBLU.meta.json"))
Description
In ES2015 (ES6), we can use template literals instead of string concatenation.
var str = `Hello, ${name}!`;
Bad Practice
var str = "Hello, " + name + "!";
var str = "Time: " + (12 * 60 * 60 * 1000);
Recommended
var str = "Hello World!";
var str = `Hello, ${name}!`;
var str = `Time: ${12 * 60 * 60 * 1000}`;
var str = "Hello, " + "World!";