Hidden goroutine GO-E1007
Bug risk
Critical
6 months ago
—
2 years old
Remove the internal goroutine and call the function using 'go'
547
548// garbage recycle for stmt
549func (s *stmtDecorator) destroy() {
550 go func() {551 s.wg.Wait()
552 _ = s.stmt.Close()
553 }()Remove the internal goroutine and call the function using 'go'
593
594// StopTask stop all tasks
595func (m *taskManager) StopTask() {
596 go func() {597 m.stop <- true
598 }()
599}
Description
Function invocations are expected to be synchronous, but this function will execute asynchronously because every instruction of the function is executed in a goroutine. Instead, it is recommended to remove the internal goroutine and call the function using 'go'.
Bad practice
func hello() {
go func() {
fmt.Println("hello world")
}()
}
func world() {
hello()
...
}
Recommended
func hello() {
fmt.Println("hello world")
}
func world() {
go hello()
...
}