Unnecessary dereference expressions GO-R4004
Anti-pattern
Major
6 months ago
—
2 years old
could simplify (*d.DateTimePtr).UTC to d.DateTimePtr.UTC
548 // in mysql, there are some precision problem, (*d.TimePtr).UTC() != timePtr.UTC()
549 assert.True(t, (*d.TimePtr).UTC().Sub(timePtr.UTC()) <= time.Second)
550 assert.True(t, (*d.DatePtr).UTC().Sub(datePtr.UTC()) <= time.Second)
551 assert.True(t, (*d.DateTimePtr).UTC().Sub(dateTimePtr.UTC()) <= time.Second) 552
553 // test support for pointer Fields using RawSeter.QueryRows()
554 var dnList []*DataNullcould simplify (*d.DatePtr).UTC to d.DatePtr.UTC
547
548 // in mysql, there are some precision problem, (*d.TimePtr).UTC() != timePtr.UTC()
549 assert.True(t, (*d.TimePtr).UTC().Sub(timePtr.UTC()) <= time.Second)
550 assert.True(t, (*d.DatePtr).UTC().Sub(datePtr.UTC()) <= time.Second) 551 assert.True(t, (*d.DateTimePtr).UTC().Sub(dateTimePtr.UTC()) <= time.Second)
552
553 // test support for pointer Fields using RawSeter.QueryRows()could simplify (*d.TimePtr).UTC to d.TimePtr.UTC
546 throwFail(t, AssertIs(*d.DecimalPtr, decimalPtr))
547
548 // in mysql, there are some precision problem, (*d.TimePtr).UTC() != timePtr.UTC()
549 assert.True(t, (*d.TimePtr).UTC().Sub(timePtr.UTC()) <= time.Second) 550 assert.True(t, (*d.DatePtr).UTC().Sub(datePtr.UTC()) <= time.Second)
551 assert.True(t, (*d.DateTimePtr).UTC().Sub(dateTimePtr.UTC()) <= time.Second)
552
Description
Avoid unnecessary dereference expressions that can be avoided by using shorthand notations (syntactic sugar) that are available in Go.
Bad practice
_ = (*str).field // replace with str.field
_ = (**str).field // replace with (*str).field
(*k)[2] = 3 // replace with k[2] = 3
Recommended
_ = str.field
_ = (*str).field
k[2] = 3