context.Context should be the first param RVV-A0002
Anti-pattern
Minor
6 months ago
—
3 years old
context.Context should be the first parameter of a function
50 }
51}
52
53func (builder *FilterChainBuilder) buildSpan(span opentracing.Span, ctx context.Context, inv *orm.Invocation) {54 span.SetTag("orm.method", inv.Method)
55 span.SetTag("orm.table", inv.GetTableName())
56 span.SetTag("orm.insideTx", inv.InsideTx)context.Context should be the first parameter of a function
63}
64
65func (builder *FilterChainBuilder) report(startTime time.Time, endTime time.Time,
66 ctx context.Context, req *httplib.BeegoHTTPRequest, resp *http.Response, err error) {67
68 proto := req.GetRequest().Proto
69
Description
context.Context should be the first parameter of a function.
Bad practice
func badPatternFunc(k favContextKey, ctx context.Context) {
// do something
}
Recommended
func goodPatternFunc(ctx context.Context, k favContextKey) {
// do something
}