Found manual trimming of string SCC-S1017
Anti-pattern
Major
5 months ago
—
3 years old
should replace this if statement with an unconditional strings.Replace
99 }
100 }
101
102 if strings.Contains(column, "%COL%") {103 column = strings.Replace(column, "%COL%", fi.Column, -1)
104 }
105
Description
Instead of using strings.HasPrefix and manual slicing, use the
strings.TrimPrefix function. The original string will be returned
if the string doesn't start with the prefix.
Using strings.TrimPrefix is idiomatic for trimming and avoids mistakes such as
off-by-one.
Bad practice
if strings.HasPrefix(str, prefix) {
str = str[len(prefix):]
}
Recommended
str = strings.TrimPrefix(str, prefix)