Simplify
make call by omitting redundant arguments SCC-S1019
Anti-pattern
Major
6 months ago
—
3 years old
should use make([]*taskerr, 100) instead
144 ErrLimit: 100,
145 SpecStr: spec,
146 // we only store the pointer, so it won't use too many space
147 Errlist: make([]*taskerr, 100, 100),148 }
149
150 for _, opt := range opts {
Description
The make function has default values for the length and capacity arguments.
- For channels and maps, the length defaults to zero.
- For slices the capacity defaults to the length.
Bad practice
ch = make(chan int, 0)
sl = make([]int, 1, 1)
Recommended
ch = make(chan int, 0)
sl = make([]int, 1, 1)
However, using named constants with channels is not considered an antipattern, for accommodating debugging, math, or platform-specific code.
const c = 0
ch = make(chan int, ch) // No issues raised