Value assigned to a variable is never read before being overwritten SCC-SA4006
Bug risk
Critical
6 months ago
—
3 years old
this value of err is never used
238 return nil, err
239 }
240 t := new(T)
241 err = s.db.ReadRaw(ctx, t, q.SQL, q.Args...)242 return t, nil
243}
this value of err is never used
272 require.NoError(t, err)
273 defer os.Remove(f)
274
275 b, err := os.ReadFile(f)276 n := bytes.Index(b, []byte("origin"))
277 require.NotEqual(t, -1, n)
278}
Description
Value has been assigned to a variable, but it is being overwritten before being read. In most cases, this could be a forgotten error check or dead code.
Bad practice
err := Op1()
// error value assigned to "err" by "Op1" is replaced with
// error value assigned by "Op2" before even being read even
// once
err = Op2()
if err != nil {
return err
}
Recommended
// Ignore the error value returned by "Op1"
Op1()
err := Op2()
if err != nil {
return err
}
err := Op1()
// Read the error value assigned to "err" by "Op1"
if err != nil {
return err
}
err = Op2()
if err != nil {
return err
}