133 throw failure;
134 }
135
136 private final class Listener implements CacheEntryCreatedListener<String, String>, Serializable {137 private static final long serialVersionUID = 1L;138139 @Override public void onCreated(140 Iterable<CacheEntryEvent<? extends String, ? extends String>> events) {141 events.forEach(event -> fallback.put(event.getKey(), event.getValue()));142 }143 }144
145 private static final class Loader implements CacheLoader<String, String> {
146 @CanIgnoreReturnValueThis nested class is declared without a static modifier, meaning all instances of the class will hold a reference to an instance of the enclosing class.
The Java analyzer has detected that there are no explicit references to the enclosing class here, meaning this nested class can be safely treated as static.
Consider adding a static modifier to the nested class.
Non-static nested classes are generally known as "inner" classes.
Bad Practice
class Outer {
class Inner {
// ...
}
// ...
}
There are a number of things one should be aware of when using inner classes:
* An instance of Inner will contain a reference to an instance of Outer.
* If the Inner instance continues to exist after all other references to the Outer instance are deleted, the Outer instance will still exist because of the reference held by the still-alive Inner class.
* The syntax for instantiating a nested class is relatively obscure, and may confuse future code maintainers.
* Referring to private fields of the enclosing class from the nested class requires Java to generate synthetic accessor methods for that sole purpose, bloating the class's bytecode.
Recommended
Declare the nested class as static if possible.
class Outer {
static class Inner {
// ...
}
// ...
}
Exceptions
If the inner class refers to the outer class's instance fields, this issue will not be reported.
References
- Oracle Java Tutorials - Nested Classes
- Oracle Java 11 Language Specification - Section 8.1.3 - Inner Classes and Enclosing Instances