ben-manes / caffeine

Conditions should not contain assignments JAVA-W1034
Bug risk
Major
3 occurrences in this check
161              Buffer<E>[] rs;
162              int mask, j;
163              if (((rs = table) != null) && ((mask = rs.length) > 0)
164                  && (rs[j = (mask - 1) & h] == null)) {165                rs[j] = create(e);
166                created = true;
167              }
2515        oldValue[0] = n.getValue();
2516        oldWeight[0] = n.getWeight();
2517        if ((nodeKey[0] == null) || (oldValue[0] == null)
2518            || hasExpired(n, now[0] = expirationTicker().read())) {2519          oldValue[0] = null;
2520          return n;
2521        }
2573        prevValue[0] = n.getValue();
2574        oldWeight[0] = n.getWeight();
2575        if ((nodeKey[0] == null) || (prevValue[0] == null) || !n.containsValue(oldValue)
2576            || hasExpired(n, now[0] = expirationTicker().read())) {2577          return n;
2578        }
2579