Unused parameter in function RVV-B0012
Bug risk
Minor
5 months ago
—
a year old
parameter 'tabstop' seems to be unused, consider removing or renaming it as _
871 displayWidth int
872}
873
874func wrapLine(input string, prefixLength int, max int, tabstop int) []wrappedLine {875 lines := []wrappedLine{}
876 width := 0
877 line := ""parameter 'windows' seems to be unused, consider removing or renaming it as _
632 r.flush()
633}
634
635func (r *LightRenderer) RefreshWindows(windows []Window) {636 r.flush()
637}
638parameter 'borderStyle' seems to be unused, consider removing or renaming it as _
37
38func (r *FullscreenRenderer) RefreshWindows(windows []Window) {}
39
40func (r *FullscreenRenderer) NewWindow(top int, left int, width int, height int, preview bool, borderStyle BorderStyle) Window {41 return nil
42}
parameter 'preview' seems to be unused, consider removing or renaming it as _
37
38func (r *FullscreenRenderer) RefreshWindows(windows []Window) {}
39
40func (r *FullscreenRenderer) NewWindow(top int, left int, width int, height int, preview bool, borderStyle BorderStyle) Window {41 return nil
42}
parameter 'left' seems to be unused, consider removing or renaming it as _
37
38func (r *FullscreenRenderer) RefreshWindows(windows []Window) {}
39
40func (r *FullscreenRenderer) NewWindow(top int, left int, width int, height int, preview bool, borderStyle BorderStyle) Window {41 return nil
42}
Description
Unused parameters in functions or methods should be replaced with _
(underscore) or removed.
Functions or methods with unused parameters can be a symptom of unfinished
refactoring or a bug. If an unused parameter is present, it should be named _
(underscore) to avoid raising this issue and better readability.
Bad practice
func abc(unused string) {
fmt.Println("Not using any passed params.")
}
Recommended
func abc(_ string) {
fmt.Println("Not using any passed params.")
}
func abc() {
fmt.Println("Not using any passed params.")
}