Useless
return detected PYL-R1711
Anti-pattern
Minor
6 months ago
—
3 years old
Useless return at end of function or method
1109 },
1110 }
1111
1112 def handle_exception(task_id, exception, traceback):1113 node_name, bundle_name, item_id = task_id.split(":", 2)
1114 io.progress_advance()
1115 if isinstance(exception, (ItemSkipped, NotImplementedError)):
Description
A single return or return None statement is found at the end of the function or method definition. This statement can safely be removed to improve the readability because Python will implicitly return None.
Bad practice
def log_data(data):
'''Sends the data to our logging API.'''
api = get_api()
api.send(data)
return # Unnecessary return
def print_pattern():
print('*')
print('**')
print('***')
return None # Unnecessary return
Recommended
def log_data(data):
'''Sends the data to our logging API.'''
api = get_api()
api.send(data)
def print_pattern():
print('*')
print('**')
print('***')